Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add port config #597

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Conversation

nathanbirrell
Copy link
Contributor

@nathanbirrell nathanbirrell commented Jul 16, 2024

Motivation

Our team already runs Docusaurus on port 3000 and we'd like to run the eventcatalog server simultaneously locally. Having a configurable port would be helpful in this case.

To do

  • update the docs — (Question: where is the docs repository? I can't find it in the repo, and the "Edit this page" links are broken)
  • consider raising a ticket for allowing complete configurability for Astro's config. ie spread an "astroConfig" onto a default base of settings.

Copy link

changeset-bot bot commented Jul 16, 2024

🦋 Changeset detected

Latest commit: 271d1ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eventcatalog/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@boyney123
Copy link
Collaborator

Thanks for the PR @nathanbirrell, nice addition.

The docs at the moment are still private, I need to work on making that public, on the list, a few I need to change on the website before I can do this, so I will add the docs no problem.

In terms of spreading Astro, I'm in two minds here. I wanted to keep astro and EventCatalog users split really (well that was the idea...), so the config is seperate from astro, but things naturally don't seem to be going that way, so if we have loads more in the future, I might just allow the spread.... let's see!

@boyney123 boyney123 merged commit 4be2512 into event-catalog:main Jul 17, 2024
2 checks passed
@boyney123
Copy link
Collaborator

@all-contributors add @nathanbirrell for code

Copy link
Contributor

@boyney123

I've put up a pull request to add @nathanbirrell! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants